From 9a334037617881836fcb76743e25375543e1f757 Mon Sep 17 00:00:00 2001 From: Sofia Date: Mon, 27 Jul 2026 01:27:38 +0300 Subject: [PATCH] Possibly fix bugs with ball in replay --- rust/src/game_manager.rs | 6 ++++-- rust/src/killbox.rs | 9 ++++++--- rust/src/map.rs | 2 ++ rust/src/player/ball.rs | 4 ++++ rust/src/player/local_player.rs | 14 ++++++++------ rust/src/player/mod.rs | 16 +++++++++++----- rust/src/player/remote_player.rs | 14 ++++++++------ rust/src/replay.rs | 11 +++++++---- 8 files changed, 50 insertions(+), 26 deletions(-) diff --git a/rust/src/game_manager.rs b/rust/src/game_manager.rs index 9bcd253..b085cf8 100644 --- a/rust/src/game_manager.rs +++ b/rust/src/game_manager.rs @@ -1162,7 +1162,9 @@ impl Game { if let Some(player) = self.find_player_mut(player_id) { if let Some(character) = &mut player.character { - character.dyn_bind_mut().take_damage(source, damage, false); + character + .dyn_bind_mut() + .take_damage(source, damage, false, true); } } } @@ -1171,7 +1173,7 @@ impl Game { pub fn handle_kill(&mut self, source: DamageSource, player_id: u16) { if let Some(player) = self.find_player_mut(player_id) { if let Some(character) = &mut player.character { - character.dyn_bind_mut().kill(source.clone()); + character.dyn_bind_mut().kill(source.clone(), true); self.on_kill(source, player_id); } } diff --git a/rust/src/killbox.rs b/rust/src/killbox.rs index 127f42b..7f5f4b5 100644 --- a/rust/src/killbox.rs +++ b/rust/src/killbox.rs @@ -70,9 +70,12 @@ impl Killbox { pub fn kill(&mut self, node: Gd) { if let Ok(mut player) = node.clone().try_dynify::() { if NetworkManager::singleton().bind().is_host() { - player - .dyn_bind_mut() - .take_damage(DamageSource::Killbox(self.kind), 1000, true); + player.dyn_bind_mut().take_damage( + DamageSource::Killbox(self.kind), + 1000, + true, + true, + ); } } else if let Ok(_) = node.try_cast::() { if let Some(game) = &mut Game::singleton() { diff --git a/rust/src/map.rs b/rust/src/map.rs index 75dbcb4..73915d5 100644 --- a/rust/src/map.rs +++ b/rust/src/map.rs @@ -145,6 +145,7 @@ impl Map { { let mut ball = ball_prefab.instantiate_as::(); ball.bind_mut().dropper = player_id; + ball.bind_mut().active = true; self.base_mut().add_child(&ball); if let Some(transform) = transform { ball.set_global_position(transform.location.into()); @@ -172,6 +173,7 @@ impl Map { { let mut ball = ball_prefab.instantiate_as::(); ball.bind_mut().dropper = player_id; + ball.bind_mut().active = false; self.base_mut().add_child(&ball); if let Some(transform) = transform { ball.set_global_position(transform.location.into()); diff --git a/rust/src/player/ball.rs b/rust/src/player/ball.rs index 4913bbc..88da701 100644 --- a/rust/src/player/ball.rs +++ b/rust/src/player/ball.rs @@ -12,6 +12,7 @@ use crate::{ #[class(base=RigidBody3D, init)] pub struct Ball { pub dropper: Option, + pub active: bool, alive_for: f64, @@ -49,6 +50,9 @@ impl Ball { } fn on_collision(&mut self, node: Gd) { + if !self.active { + return; + } if let Ok(player) = node.try_dynify::() && let Some(player_id) = player.dyn_bind().get_player_id() { diff --git a/rust/src/player/local_player.rs b/rust/src/player/local_player.rs index 7623d68..ad58fe7 100644 --- a/rust/src/player/local_player.rs +++ b/rust/src/player/local_player.rs @@ -171,7 +171,7 @@ impl IPlayer for LocalPlayer { fn apply_look_up(&mut self, _look: f32) {} fn try_shoot(&mut self, to: Vector3, deal_damage: bool) -> bool { - if self.try_shoot_common(to, deal_damage) { + if self.try_shoot_common(to, deal_damage, deal_damage) { if let Some(game) = &mut Game::singleton() && let Some(recorder) = game.bind_mut().recorder() { @@ -209,7 +209,7 @@ impl IPlayer for LocalPlayer { } } - fn take_damage(&mut self, source: DamageSource, damage: i32, kill: bool) { + fn take_damage(&mut self, source: DamageSource, damage: i32, kill: bool, drop_ball: bool) { self.run_deferred(move |s| { if s.can_take_damage(&source) { let (signal, player, kind) = source.into_signal(); @@ -220,7 +220,7 @@ impl IPlayer for LocalPlayer { }); s.health -= damage; if kill && s.health <= 0 { - s.kill(source); + s.kill(source, drop_ball); } } if let Some(health_label) = &mut s.health_label { @@ -237,8 +237,10 @@ impl IPlayer for LocalPlayer { self.dead_for } - fn kill(&mut self, source: DamageSource) { - self.drop_ball(false); + fn kill(&mut self, source: DamageSource, drop_ball: bool) { + if drop_ball { + self.drop_ball(false); + } let (signal, player, kind) = source.into_signal(); self.run_deferred(move |s| s.signals().on_die().emit(signal, player, kind)); @@ -719,6 +721,6 @@ impl LocalPlayer { #[godot_dyn] impl Shootable for LocalPlayer { fn on_shoot(&mut self, source: DamageSource, damage: i32, _: Vector3) { - self.take_damage(source, damage, true); + self.take_damage(source, damage, true, true); } } diff --git a/rust/src/player/mod.rs b/rust/src/player/mod.rs index 868b597..0f182cb 100644 --- a/rust/src/player/mod.rs +++ b/rust/src/player/mod.rs @@ -47,9 +47,15 @@ pub trait IPlayer { fn jump(&mut self); fn try_shoot(&mut self, to: Vector3, deal_damage: bool) -> bool; fn try_punch(&mut self, to: Vector3, deal_damage: bool) -> bool; - fn take_damage(&mut self, source_player: DamageSource, damage: i32, kill: bool); + fn take_damage( + &mut self, + source_player: DamageSource, + damage: i32, + kill: bool, + drop_ball: bool, + ); fn is_dead(&self) -> bool; - fn kill(&mut self, source_player: DamageSource); + fn kill(&mut self, source_player: DamageSource, drop_ball: bool); fn dead_for(&self) -> f64; fn swap_weapon(&mut self, weapon: WeaponType, drop_ball: bool); fn get_weapon(&self) -> Option>; @@ -64,7 +70,7 @@ pub trait PlayerCommon { fn drop_ball_common(&mut self, with_velocity: bool) -> bool; fn get_look_dir(&self) -> Vector3; fn can_take_damage(&self, source: &DamageSource) -> bool; - fn try_shoot_common(&mut self, to: Vector3, deal_damage: bool) -> bool; + fn try_shoot_common(&mut self, to: Vector3, deal_damage: bool, drop_ball: bool) -> bool; fn try_punch_common(&mut self, to: Vector3, deal_damage: bool) -> bool; } @@ -176,12 +182,12 @@ impl PlayerCommon for T { true } - fn try_shoot_common(&mut self, to: Vector3, deal_damage: bool) -> bool { + fn try_shoot_common(&mut self, to: Vector3, deal_damage: bool, drop_ball: bool) -> bool { if self.is_dead() { return false; } - if self.drop_ball(true) { + if drop_ball && self.drop_ball(true) { return true; } diff --git a/rust/src/player/remote_player.rs b/rust/src/player/remote_player.rs index 7f353a1..3bd0d7a 100644 --- a/rust/src/player/remote_player.rs +++ b/rust/src/player/remote_player.rs @@ -126,7 +126,7 @@ impl IPlayer for RemotePlayer { } fn try_shoot(&mut self, to: Vector3, deal_damage: bool) -> bool { - self.try_shoot_common(to, deal_damage) + self.try_shoot_common(to, deal_damage, deal_damage) } fn try_punch(&mut self, to: Vector3, deal_damage: bool) -> bool { @@ -138,7 +138,7 @@ impl IPlayer for RemotePlayer { } } - fn take_damage(&mut self, source: DamageSource, damage: i32, kill: bool) { + fn take_damage(&mut self, source: DamageSource, damage: i32, kill: bool, drop_ball: bool) { self.run_deferred(move |s| { if s.can_take_damage(&source) { let (signal, player, kind) = source.into_signal(); @@ -149,7 +149,7 @@ impl IPlayer for RemotePlayer { }); s.health -= damage; if kill && s.health <= 0 { - s.kill(source); + s.kill(source, drop_ball); } } if let Some(health_bar) = &mut s.health_bar { @@ -167,8 +167,10 @@ impl IPlayer for RemotePlayer { self.dead_for } - fn kill(&mut self, source: DamageSource) { - self.drop_ball(false); + fn kill(&mut self, source: DamageSource, drop_ball: bool) { + if drop_ball { + self.drop_ball(false); + } let (signal, player, kind) = source.into_signal(); self.run_deferred(move |s| s.signals().on_die().emit(signal, player, kind)); @@ -286,6 +288,6 @@ impl RemotePlayer { #[godot_dyn] impl Shootable for RemotePlayer { fn on_shoot(&mut self, source: DamageSource, damage: i32, _: Vector3) { - self.take_damage(source, damage, true); + self.take_damage(source, damage, true, true); } } diff --git a/rust/src/replay.rs b/rust/src/replay.rs index c0d8c17..3cc0548 100644 --- a/rust/src/replay.rs +++ b/rust/src/replay.rs @@ -197,7 +197,7 @@ impl INode for ReplayPlayback { match event { ReplayEvent::Death(damage_source, player_id) => { if let Some(character) = self.player_characters.get_mut(player_id) { - character.bind_mut().kill(*damage_source); + character.bind_mut().kill(*damage_source, false); } } ReplayEvent::Shoot(player_id, to) => { @@ -234,9 +234,12 @@ impl INode for ReplayPlayback { } ReplayEvent::TakeDamage(player_id, damage_source, damage) => { if let Some(character) = self.player_characters.get_mut(player_id) { - character - .bind_mut() - .take_damage(*damage_source, *damage, false); + character.bind_mut().take_damage( + *damage_source, + *damage, + false, + false, + ); } } }